-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version information #177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hikinggrass
force-pushed
the
feature/add-version-information
branch
from
April 5, 2024 10:31
97866c2
to
7b2f795
Compare
hikinggrass
force-pushed
the
feature/add-version-information
branch
2 times, most recently
from
April 22, 2024 10:35
6df8547
to
f359187
Compare
This adds the Unix/Linux traditional commmand line argument "--version" so that it is possible to retrieve the version of the binary. Example output: /usr/bin/manager (everest-framework 0.10.1) Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
The generated code of each C++ module uses the module loader for processing command line parameters etc. This is why we have to extend the class and pass the version information from the generated files into the framework library here. Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
change project_name and project_version paramters to a struct VersionInformation that also includes a git_version member Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
It is now automatically generated in ${CMAKE_CURRENT_BINARY_DIR}/generated/include/version_information.hpp Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
This file can be generated during a build of everest-core Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
generate version info header directly Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
This has no version information (for now) Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
hikinggrass
force-pushed
the
feature/add-version-information
branch
from
June 13, 2024 10:06
f359187
to
0a415c2
Compare
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
andistorm
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…nformation # Conflicts: # CMakeLists.txt Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This outputs version information in the manager on startup and when passed a --version parameter on the command line